Fix broken OpenAI batch trigger test blocking main - #70938
Merged
Conversation
Two PRs merged three hours apart on 2026-08-01 collided semantically: apache#69506 added a test using the class attribute END_TIME, and apache#69534 renamed that attribute to LEGACY_END_TIME while branched off a main that predated apache#69506. Git merged both cleanly, so the dangling reference reached main unnoticed and every job that collects the OpenAI provider tests now fails. The case asserts that a terminal batch emits exactly one event, which has nothing to do with the deprecated wall-clock deadline, so it moves to the timeout constant that the rest of the behavioural cases use rather than to LEGACY_END_TIME. The end_time path stays covered by test_serialization_with_legacy_end_time.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
providers/openai/tests/unit/openai/triggers/test_openai.pystill referencesself.END_TIME, which was renamed toLEGACY_END_TIMEin #69534. As a result,test_openai_batch_yields_single_terminal_eventfails withAttributeError.The stale reference is the result of a semantic merge conflict with #69506,
which introduced the test using
self.END_TIME.Change
Switch the test to
timeout=self.TIMEOUT, matching every other behavioral testin the file.
The deprecated
end_timepath remains covered bytest_serialization_with_legacy_end_time.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines